Add playwright tests for gitDiff

[standeren]

Description

These tests can include these cases f.ex:

•  Add test for viewing gitDiff after altering an existing file
• Add test for viewing gitDiff after altering the repo with a new file (new page f.ex)
• Add test for viewing gitDiff after altering the repo with deleting a file (delete page or data model f.ex)
•  Add test for viewing gitDiff after adding a file and deleting it - it should not be listed
•  Add test for viewing gitDiff after adding an image - should see a text saying that a binary file has been added (This one can be added after image-upload is merged)

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

[nkylstad]

Maybe you've already discussed this, but do we need tests this detailed and specific in our e2e-tests? Is this not something we test in unit tests? If we feel we need to include gitDiff in the e2e-tests, then a single scenario as part of editing an app might be enough?
@standeren @framitdavid

[framitdavid]

Maybe you've already discussed this, but do we need tests this detailed and specific in our e2e-tests? Is this not something we test in unit tests? If we feel we need to include gitDiff in the e2e-tests, then a single scenario as part of editing an app might be enough? @standeren @framitdavid

In my opinion, this test is too detailed for Playwright. The feature in question may not be significant enough to benefits a Playwright test. Since the primary function is just viewing the diff, users can commit or revert if the diff view is broken or not functioning correctly. Therefore, I believe this feature can be adequately tested with unit tests, which should be sufficient.

e2e-tests costs more and runs slowly compared to unit-tests and I think that we should test critical features with Playwright.

[standeren]

Should we close this then? 😊