Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other files than text-resources in config/texts folder #11869

Closed
nkylstad opened this issue Dec 15, 2023 · 1 comment · Fixed by #11915
Closed

Allow other files than text-resources in config/texts folder #11869

nkylstad opened this issue Dec 15, 2023 · 1 comment · Fixed by #11915
Labels
kind/bug Used when there is a defect / something is not working as it should. status/triage

Comments

@nkylstad
Copy link
Member

Description of the bug

All file names in the App/config/texts folder are used to fetch text resources for an app in Studio. However, if someone adds a custom code file or similar, the page displays an error message because files that are not text resources are also something our code attempts to fetch as if they were text resources.

We should consider adding a filter/regex when we read filenames from the texts folder, so that we only attempt to fetch the relevant files.

Steps To Reproduce

  1. Go to an app in repos, and navigate to the App/config/texts folder
  2. Add a new file and name it f.ex. testing.js, and commit
  3. Go to the app in designer and fetch changes
  4. Go to the texts page and see that an error message is shown
  5. See in the network log that the languages endpoint returns js as one of the options
  6. See in the network log that fetching resource.js.json fails

Additional Information

It is the languages endpoint that returns a list that is wrong.

@nkylstad nkylstad added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Dec 15, 2023
@nkylstad nkylstad moved this to 📈 Todo in Team Studio Dec 19, 2023
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Dec 22, 2023
@standeren standeren self-assigned this Dec 22, 2023
@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Dec 23, 2023
@standeren standeren removed their assignment Dec 23, 2023
@JamalAlabdullah JamalAlabdullah moved this from 🔎 Review to 👷 In Progress in Team Studio Dec 26, 2023
@github-project-automation github-project-automation bot moved this from 👷 In Progress to 🧪 Test in Team Studio Dec 29, 2023
@JamalAlabdullah JamalAlabdullah self-assigned this Dec 29, 2023
@JamalAlabdullah
Copy link
Contributor

Tested ok

@JamalAlabdullah JamalAlabdullah moved this from 🧪 Test to ✅ Done in Team Studio Dec 29, 2023
@JamalAlabdullah JamalAlabdullah removed their assignment Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Used when there is a defect / something is not working as it should. status/triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants