Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis workflow reports failing tests when all tests pass #594

Closed
acn-sbuad opened this issue Aug 19, 2024 · 4 comments
Closed

Analysis workflow reports failing tests when all tests pass #594

acn-sbuad opened this issue Aug 19, 2024 · 4 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@acn-sbuad
Copy link
Contributor

acn-sbuad commented Aug 19, 2024

Description of the bug

see title.

Issue created in repo of action creator NasAmin/trx-parser#311
Example workflow run: https://github.com/Altinn/altinn-notifications/actions/runs/10453675204/job/28944613679

Steps To Reproduce

Currently disabled tasks in workflow: https://github.com/Altinn/altinn-notifications/blob/main/.github/workflows/build-and-analyze.yml
Remove comments and trigger workflow to reproduce error.

@acn-sbuad acn-sbuad added the kind/bug Something isn't working label Aug 19, 2024
@acn-sbuad acn-sbuad self-assigned this Aug 19, 2024
@SandGrainOne
Copy link
Member

Are we able to download the trx files to review them?

In some of the cases I've seen there have been errors after the tests have been run:
The active test run was aborted. Reason: Test host process crashed : Unhandled exception. Npgsql.PostgresException (0x80004005): 53300: remaining connection slots are reserved for non-replication superuser connections

It could be that it does something to the report files.

@acn-sbuad
Copy link
Contributor Author

acn-sbuad commented Aug 20, 2024

@SandGrainOne We would need to adapt the workflow to be able to download the reports.

In the case you added to the example the Build&Test step actually fails and does not exit with a success code. This is not the same as the case. Removing the additional information, to make the issue clear.

In the current case, there are no logs indicating that anything has failed.

@acn-sbuad
Copy link
Contributor Author

Could not reproduce as of now. Made test report available as an artifact so we can check closer if it is to occur again.

@acn-sbuad
Copy link
Contributor Author

acn-sbuad commented Aug 21, 2024

Test reports show that an error message being logged when connecting to the kafka broker is causing the test run to be determined as failed. The error message Failed to acquire idempotence PID from broker localhost:9092/1: Broker: Coordinator load in progress: retrying. It is reasonable to assume that retry is successful as all test that depend on kafka are successful. Question is how we avoid the error message or ensure it does not break the final result of the test run.

Testrun file is available as an artifact on the workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants