Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository logic for placing a SMS notifications order #337

Closed
13 tasks done
Tracked by #201
acn-sbuad opened this issue Dec 8, 2023 · 0 comments
Closed
13 tasks done
Tracked by #201

Repository logic for placing a SMS notifications order #337

acn-sbuad opened this issue Dec 8, 2023 · 0 comments
Assignees
@acn-sbuad
Labels
kind/user-story Used for issues that describes functionality for our users.

Comments

@acn-sbuad
Copy link
Contributor

acn-sbuad commented Dec 8, 2023 •
edited
Loading

Description

Workflow: order placement for SMS notifications will need modifications to the persistence layer of the notification app that can support the new endpoint.

Consideration

Split into smaller repository classes. GetOrderRepository, CreateOrderRepository, UpdateOrderRepository (?)

Tasks

  • Define SMS texts table
  • Create migration scripts for setting up SMS texts table
  • Add logic for retrieving SMS template in ExtractTemplates in OrderRepository.cs
  • Implement function for inserting sms texts
  • Implement logic for calling new function when required
  • Change task handling to insert sms and email in parallel and waiting for both tasks at the end
  • Implement unit tests
  • Implement integration tests
  • QA
  • Manual testing (if API endpoint is available)

Acceptance Criterias

  • An SMS texts table exists in the database
  • Once an order is placed the order including sms template is persisted in the jsonb
  • Once an order is places the sms text is persisted in the SMS texts table
@acn-sbuad acn-sbuad mentioned this issue Dec 8, 2023
Closed
3 tasks
@acn-sbuad acn-sbuad changed the title Add necessary Repository logic and database objects Repository logic for placing a SMS notifications order Dec 8, 2023
@acn-sbuad acn-sbuad added the kind/user-story Used for issues that describes functionality for our users. label Dec 11, 2023
@acn-sbuad acn-sbuad self-assigned this Jan 22, 2024
acn-sbuad added a commit that referenced this issue Jan 22, 2024
@acn-sbuad
#337 persisting sms texts as part of order creation #GCPActive
16aaef3
@acn-sbuad acn-sbuad mentioned this issue Jan 22, 2024
Merged
3 tasks
acn-sbuad added a commit that referenced this issue Jan 25, 2024
@acn-sbuad
#337 persisting sms texts as part of order creation #GCPActive (#385)
39bfb51 
* #337 persisting sms texts as part of order creation #GCPActive

* added unit test

* fixed namespace for interfaces

* removed unused dep

* added cleanup of testdata #GCPActive

* Fixed code smells

* fixed pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acn-sbuad acn-sbuad

Labels
kind/user-story Used for issues that describes functionality for our users.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acn-sbuad