Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing colorizing the last dot #2

Open
pmilanez opened this issue Nov 8, 2013 · 3 comments
Open

Missing colorizing the last dot #2

pmilanez opened this issue Nov 8, 2013 · 3 comments

Comments

@pmilanez
Copy link

pmilanez commented Nov 8, 2013

During the process of defining the PIN or entering, the last dot is never painted because the code go fast do go back.

So I've changed the following calls:
[self checkForEnteredPin];

To:
[self performSelector:@selector(checkForEnteredPin) withObject:self afterDelay:0.5];

So now it have time to paint the last dot and make the user understand better what is happening.

What do you think?

@Krivoblotsky
Copy link
Contributor

Yep, we are thinking about it now, but we also need to "block" UI/UX while waiting 0.5 secs to not receive keyboard input and other events. We'll submit new version in some days with this improvement.
Thanks for the feedback!

@pmilanez
Copy link
Author

pmilanez commented Nov 8, 2013

True true..
Thanks for your attention!

@nicarq
Copy link
Contributor

nicarq commented Jul 30, 2014

For APPinViewcontroller in a fork, I used:

#pragma mark - Pin Code View Delegate
- (void)pinCodeView:(APPinView*)view didEnterPin:(NSString*)pinCode
{
    // Small Hack to give time to show the last entered number
    double delayInSeconds = 0.15;
    dispatch_time_t popTime = dispatch_time(DISPATCH_TIME_NOW, delayInSeconds * NSEC_PER_SEC);
    dispatch_after(popTime, dispatch_get_main_queue(), ^(void){

        view.pinCode = nil;

        //Verify case
        if (self.pinCodeToCheck != nil && !self.shouldResetPinCode) {
            [self verifyPinWithEntered:pinCode];
        } else if (self.pinCodeToCheck != nil && self.shouldResetPinCode) {
            [self changePinWithEntered:pinCode];
        } else {
            [self setEnteredPin:pinCode];
        }
    });
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants