Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make settings page #9

Open
2 of 3 tasks
adam-ce opened this issue Feb 14, 2023 · 4 comments
Open
2 of 3 tasks

make settings page #9

adam-ce opened this issue Feb 14, 2023 · 4 comments

Comments

@adam-ce
Copy link
Member

adam-ce commented Feb 14, 2023

  • design qml page for settings (for now frame limitter + lod resolution)
  • wire up with qsettings (test persistence on android)
  • wire up with renderer
@adam-ce
Copy link
Member Author

adam-ce commented Feb 18, 2023

think about where to read/write qsettings (probably there is best practise):

  • we don't want to pollute nucleus and gl_engine with qsettings (separation of concerns, dependencies)
  • qsettings has no notification, so can't set on settings page and let qsettings notify objects => settings page needs to notify objects / set directly
  • can't write in destructors (apps are often killed spontaneously)

@adam-ce
Copy link
Member Author

adam-ce commented May 22, 2023

there is possibility of crashing settings (e.g. number of GPU cached tiles later on). think about how to handle that more or less gracefully.

@GeraldKimmersdorfer
Copy link
Contributor

GeraldKimmersdorfer commented Nov 20, 2023

I used qsettings inside the new AppSettings class. It is currently commented out though, because:

  • it just saves the frontend settings (datetime, quality, ...) but not for example the gl configuration
  • it is confusing and i like to start with a clean slate whenever i start the app (at least on desktop)

For the android app it might be a good idea though!

@adam-ce
Copy link
Member Author

adam-ce commented Nov 20, 2023

you have a good point with the clean slate. that could be a command line parameter, or a build parameter.

@adam-ce adam-ce mentioned this issue Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants