Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-threaded on alpinemaps.org (not all versions work on iphone) #35

Open
adam-ce opened this issue Jun 2, 2023 · 3 comments
Open
Labels
future New feature or request

Comments

@adam-ce
Copy link
Member

adam-ce commented Jun 2, 2023

going through the versions on https://gataki.cg.tuwien.ac.at/ and testing with chrome / safari on iOS:
non-threaded versions work. threaded versions go out of memory. maybe we need to limit the memory size for the web workers.

@adam-ce
Copy link
Member Author

adam-ce commented Jun 3, 2023

ios user agent strings:
safari: Mozilla/5.0 (iPhone; CPU iPhone OS 16_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Mobile/15E148 Safari/604.1

chrome: Mozilla/5.0 (iPhone; CPU iPhone OS 16_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/113.0.5672.121 Mobile/15E148 Safari/604.1

@adam-ce
Copy link
Member Author

adam-ce commented Nov 17, 2023

also crashes in the single threaded version after some time. probably the limit is around 300mib (thanks for the link joey):
https://stackoverflow.com/questions/74506298/how-much-the-memory-limitation-is-on-the-ios-device-browser

@adam-ce adam-ce changed the title not all versions work on iphone Multi-threaded on alpinemaps.org (not all versions work on iphone) Dec 1, 2023
@adam-ce
Copy link
Member Author

adam-ce commented Dec 1, 2023

for the memory limit, we can't detect that beforehand. so we probably want a watchdog implemented in JS with the following algorithm:

start multithreaded -> if it crashes, start singlethreaded -> if it crashes, start singlethreaded with a tighter tile limit.

i don't know whether this can even work, or the whole tab crashes and JS stops working altogether.

@adam-ce adam-ce added the future New feature or request label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant