Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Refactor Injection models into different types #1188

Open
2 tasks
dbirman opened this issue Dec 6, 2024 · 1 comment
Open
2 tasks

[2.0] Refactor Injection models into different types #1188

dbirman opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
breaking Breaking changes

Comments

@dbirman
Copy link
Member

dbirman commented Dec 6, 2024

Is your feature request related to a problem? Please describe.
@saskiad Please expand on goals

Describe the solution you'd like

  • TBD
  • Upgrader from v1.x to 2.0
@dbirman dbirman added the breaking Breaking changes label Dec 6, 2024
@saskiad
Copy link
Collaborator

saskiad commented Dec 7, 2024

I think this is something @dyf wanted. Is the idea to not have the Injection and BrainInjection classes that get inherited by NanojectInjection and Iontophoresis and just repeat all those fields?

I do think we can consider removing:

  • recovery time
  • instrument_id
  • duration
  • bregma_to_lambda_distance (though this might be good)

These are things NSB tracks but could be in a AIND extension if we really want to keep them

@saskiad saskiad added this to the v2.0 milestone Jan 2, 2025
@dbirman dbirman self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

No branches or pull requests

2 participants