Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainer registers subjects with Metric #36

Open
mochic opened this issue Jun 3, 2024 · 1 comment
Open

Trainer registers subjects with Metric #36

mochic opened this issue Jun 3, 2024 · 1 comment
Milestone

Comments

@mochic
Copy link

mochic commented Jun 3, 2024

Trainer currently initializes subjects with Metric when calling register_subject. Our starting policy for our curriculum operates on our own Metric subclass which forces us to include code that handles this edgecase in our initialization policy.

@bruno-f-cruz bruno-f-cruz added this to the Next release milestone Jun 4, 2024
@mochic
Copy link
Author

mochic commented Jun 9, 2024

This might not be necessary if we calculate metrics at trainer evaluation time (pulling from slims). I also kinda only encounter this problem due to my current implementation but after switching to the implementation @dyf mentioned, this will probably not be an issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants