Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend zeromq PUB filters for TP updates #2157

Open
1 of 2 tasks
t-b opened this issue Jul 2, 2024 · 2 comments · May be fixed by #2230
Open
1 of 2 tasks

Extend zeromq PUB filters for TP updates #2157

t-b opened this issue Jul 2, 2024 · 2 comments · May be fixed by #2230
Assignees
Labels

Comments

@t-b
Copy link
Collaborator

t-b commented Jul 2, 2024

Multiple options:

  • as fast as possible
  • every X seconds

Send out "Testpulse Cycle Id" with timestamps (increase to sub second accuracy) and TP index in that cycle.

This avoids client having to poll updates. Only publish updates when the testpulse is running.

Tim:

  • Clarify with @campagnola if we need to send out the timeseries as well in addition to the features (resistances etc.) we extracted
  • Think about a way for external users to query a single stored TP
@t-b t-b added bug Something isn't working Testpulse ZeroMQ XOP PatchLink labels Jul 2, 2024
@campagnola
Copy link
Member

Yes, it would be nice if MIES could optionally return the timeseries data from each test pulse (recording + command).

@MichaelHuth
Copy link
Collaborator

MichaelHuth commented Aug 14, 2024

Use TPMarker as index for single TP.

Testpulse Cycle Id is constant over all TPs from one acquisition run.

Publish zeromq from TP_TSAnalysis thread function

Use TUF-XOP to save last publishing time for 1s 5s and 10s publishing clock.
(four different publishers)

Instead of retrieving the timestamp in TP_RecordTP, retrieve it when the TP data is pushed to the thread and also push time stamp. Use this time stamp in the JSON as well as in TP_RecordTP then. (only single timestamp)

Part II TP retrieval:

One function that has a related functionality: TP_GetStoredTPs

  • rename TP_GetStoredTPs to TP_GetConsecutiveTPsUptoMarker
  • add a function that retrieves single TPs, with arg that allows to choose if DA data is included as well (DA data must be recreated through TP_CreateTestPulseWaveImpl)
  • add a function that retrieves multiple TPs from TP Cycle id, with arg that allows to choose if DA data is included as well
  • move core TP data getter to static utility functions and also use that in TP_GetConsecutiveTPsUptoMarker
  • no optional arguments for API functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants