Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including phpunit ad dev dependency causes CI to broke #72

Closed
Algatux opened this issue Jul 28, 2017 · 7 comments
Closed

Including phpunit ad dev dependency causes CI to broke #72

Algatux opened this issue Jul 28, 2017 · 7 comments

Comments

@Algatux
Copy link
Owner

Algatux commented Jul 28, 2017

Including phpunit ad dev dependency causes CI to broke when the --prefer-lowest composer flag is applied

see dependecies_update branch

@soullivaneuh
Copy link
Collaborator

Is this issue still relevant? PHPUnit is not a dependency anymore here.

@Algatux
Copy link
Owner Author

Algatux commented Nov 8, 2017

I gas thinking to rei produce it because of some issues on ci

@Algatux
Copy link
Owner Author

Algatux commented Nov 8, 2017

I was thinking to reintroduce it because of some issues on the ci In prefer lowest

@soullivaneuh
Copy link
Collaborator

What kind of issue do you have? The last build looks good: https://travis-ci.org/Algatux/influxdb-bundle/jobs/299017351

@Algatux
Copy link
Owner Author

Algatux commented Nov 8, 2017

If take a look at the log:

$ vendor/bin/phpunit -c . --coverage-clover=./build/coverage/coverage.xml PHPUnit 2.1.2-4-gac49e2a by Sebastian Bergmann and contributors. ...........................WWWWW..str_repeat(): Second argument has to be greater than or equal to 0

Maybe it's a phpunit bug, dunno (look at the output and to phpunit version)

TAking a look to phpunit code it semmes that it takes the git tag version as his own version .... ugly!

@soullivaneuh
Copy link
Collaborator

Ok I don't understand. From where come this log? Travis does not use vendor phpunit bin.

You told:

I was thinking to reintroduce it because of some issues on the ci In prefer lowest

But why re-introduce the phpunit as dependency if it is causing issue? ^^"

BTW, the phpunit from vendor is not reliable because the phpunit use dependency according to the composer.json and not the composer.lock file where phar are built. This is why it's recommended to use phar files IMO.

@soullivaneuh
Copy link
Collaborator

We can consider this issue as irrelevant anymore. PHPUnit is not a dev dependency anymore since the migration to GitHub actions (#99).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants