Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Updating PDF.js causes related unit tests to fail #9738

Conversation

g-jaskowski
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@g-jaskowski g-jaskowski requested a review from MichalKinas May 27, 2024 12:09
@g-jaskowski g-jaskowski force-pushed the ACS-7932-Updating-PDF.js-causes-related-unit-tests-to-fail branch from c7cfcc5 to fea50d5 Compare June 3, 2024 11:39
Copy link
Contributor

@nikita-web-ua nikita-web-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to trigger unit tests

@g-jaskowski g-jaskowski force-pushed the ACS-7932-Updating-PDF.js-causes-related-unit-tests-to-fail branch from afa960e to 7cca943 Compare June 4, 2024 09:54
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@g-jaskowski g-jaskowski closed this Jun 5, 2024
@g-jaskowski g-jaskowski deleted the ACS-7932-Updating-PDF.js-causes-related-unit-tests-to-fail branch June 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants