Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-6239] Migrated personal files of pagination suit to playwright #3528

Merged
merged 7 commits into from
Nov 23, 2023
Merged

[ACS-6239] Migrated personal files of pagination suit to playwright #3528

merged 7 commits into from
Nov 23, 2023

Conversation

kritagya09
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Protractor is deprecated.

What is the new behaviour?
Migrating protractor test case into playwright test case and now it passing.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-6239

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit f705c46 into develop Nov 23, 2023
30 checks passed
@DenysVuika DenysVuika deleted the dev-kritagy-ACS-6239 branch November 23, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@eromano eromano Awaiting requested review from eromano

@rbahirsheth rbahirsheth Awaiting requested review from rbahirsheth

@MichalKinas MichalKinas Awaiting requested review from MichalKinas

@akashrathod28 akashrathod28 Awaiting requested review from akashrathod28

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kritagya09 @DenysVuika @akashrathod28 @MichalKinas @AleksanderSklorz