From d4ddb48dd26a159f8ba116f562e4c7e65809b620 Mon Sep 17 00:00:00 2001 From: "akash.rathod@hyland.com" Date: Wed, 27 Dec 2023 10:40:36 +0100 Subject: [PATCH] add e2e test suite for copy-action --- .github/workflows/pull-request.yml | 2 ++ e2e/playwright/copy-move-actions/playwright.config.ts | 4 ++-- projects/aca-playwright-shared/src/api/file-actions.ts | 4 ++-- projects/aca-playwright-shared/src/api/nodes-api.ts | 4 ++-- projects/aca-playwright-shared/src/api/search-api.ts | 2 +- projects/aca-playwright-shared/src/api/shared-links-api.ts | 2 +- .../src/page-objects/components/conditions.component.ts | 4 ---- 7 files changed, 10 insertions(+), 12 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index c19fad2a31..12a115bd8f 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -176,6 +176,8 @@ jobs: id: 7 - name: "list-views" id: 8 + - name: "copy-move-actions" + id: 9 steps: - name: Checkout uses: actions/checkout@v3 diff --git a/e2e/playwright/copy-move-actions/playwright.config.ts b/e2e/playwright/copy-move-actions/playwright.config.ts index f968d6f381..14fe84141e 100644 --- a/e2e/playwright/copy-move-actions/playwright.config.ts +++ b/e2e/playwright/copy-move-actions/playwright.config.ts @@ -29,10 +29,10 @@ import EXCLUDED_JSON from './exclude.tests.json'; const config: PlaywrightTestConfig = { ...getGlobalConfig, - grepInvert: getExcludedTestsRegExpArray(EXCLUDED_JSON, 'Copy Move Actions'), + grepInvert: getExcludedTestsRegExpArray(EXCLUDED_JSON, 'copy-move-actions'), projects: [ { - name: 'Copy Move Actions', + name: 'copy-move-actions', testDir: './src/tests', use: { users: ['hruser'] diff --git a/projects/aca-playwright-shared/src/api/file-actions.ts b/projects/aca-playwright-shared/src/api/file-actions.ts index 1e67b1957c..870ef93aaf 100644 --- a/projects/aca-playwright-shared/src/api/file-actions.ts +++ b/projects/aca-playwright-shared/src/api/file-actions.ts @@ -43,7 +43,7 @@ export class FileActionsApi { async uploadFile(fileLocation: string, fileName: string, parentFolderId: string): Promise { const file = fs.createReadStream(fileLocation); - return this.apiService.upload.uploadFile(file, '', parentFolderId, null, { + return await this.apiService.upload.uploadFile(file, '', parentFolderId, null, { name: fileName, nodeType: 'cm:content', renditions: 'doclib' @@ -149,7 +149,7 @@ export class FileActionsApi { }; try { - return this.apiService.search.search(data); + return await this.apiService.search.search(data); } catch (error) { Logger.error(`SearchApi queryNodesNames : catch : `, error); return new ResultSetPaging(); diff --git a/projects/aca-playwright-shared/src/api/nodes-api.ts b/projects/aca-playwright-shared/src/api/nodes-api.ts index 3ef94b0883..50d9609eab 100755 --- a/projects/aca-playwright-shared/src/api/nodes-api.ts +++ b/projects/aca-playwright-shared/src/api/nodes-api.ts @@ -130,7 +130,7 @@ export class NodesApi { async renameNode(nodeId: string, newName: string): Promise { try { - return this.apiService.nodes.updateNode(nodeId, { name: newName }); + return await this.apiService.nodes.updateNode(nodeId, { name: newName }); } catch (error) { console.error(`${this.constructor.name} ${this.renameNode.name}`, error); return null; @@ -335,7 +335,7 @@ export class NodesApi { private async addAspects(nodeId: string, aspectNames: string[]): Promise { try { - return this.apiService.nodes.updateNode(nodeId, { aspectNames }); + return await this.apiService.nodes.updateNode(nodeId, { aspectNames }); } catch (error) { console.error(`${this.constructor.name} ${this.addAspects.name}`, error); return null; diff --git a/projects/aca-playwright-shared/src/api/search-api.ts b/projects/aca-playwright-shared/src/api/search-api.ts index ecc90b2b30..28b92a5c13 100755 --- a/projects/aca-playwright-shared/src/api/search-api.ts +++ b/projects/aca-playwright-shared/src/api/search-api.ts @@ -53,7 +53,7 @@ export class SearchPageApi { }; try { - return this.apiService.search.search(data); + return await this.apiService.search.search(data); } catch (error) { Logger.error(`SearchApi queryRecentFiles : catch : `, error); return new ResultSetPaging; diff --git a/projects/aca-playwright-shared/src/api/shared-links-api.ts b/projects/aca-playwright-shared/src/api/shared-links-api.ts index 0a551213e4..7687036e34 100755 --- a/projects/aca-playwright-shared/src/api/shared-links-api.ts +++ b/projects/aca-playwright-shared/src/api/shared-links-api.ts @@ -89,7 +89,7 @@ export class SharedLinksApi { } }; - return Utils.retryCall(sharedFile); + return await Utils.retryCall(sharedFile); } catch (error) { console.error(`SharedLinksApi waitForFilesToBeShared : catch : ${error}`); console.error(`\tWait timeout reached waiting for files to be shared`); diff --git a/projects/aca-playwright-shared/src/page-objects/components/conditions.component.ts b/projects/aca-playwright-shared/src/page-objects/components/conditions.component.ts index a3bb86c5a5..23d7e76428 100644 --- a/projects/aca-playwright-shared/src/page-objects/components/conditions.component.ts +++ b/projects/aca-playwright-shared/src/page-objects/components/conditions.component.ts @@ -41,10 +41,6 @@ export enum Comparator { export class ConditionComponent extends ManageRulesDialogComponent { private getOptionLocator = (optionName: string): Locator => this.page.locator(`.cdk-overlay-pane .mat-option span`, { hasText: optionName }); - constructor(page: Page) { - super(page); - } - private async selectField(fields: Partial, index: number): Promise { await this.fieldDropDown.nth(index).click(); const option = this.getOptionLocator(fields);