From 84c111dde9c17b7e4efaa7050cc0b520b49669a4 Mon Sep 17 00:00:00 2001 From: "swapnil.verma" Date: Wed, 22 Nov 2023 12:48:49 +0530 Subject: [PATCH] [ACS-5014] Addressed code review findings. Removed unused methods/objects from content-node-selector-dialog.ts --- .../dialog/content-node-selector-dialog.ts | 20 +------------------ 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/projects/aca-testing-shared/src/components/dialog/content-node-selector-dialog.ts b/projects/aca-testing-shared/src/components/dialog/content-node-selector-dialog.ts index fdb8162f69..8d8b3b3732 100755 --- a/projects/aca-testing-shared/src/components/dialog/content-node-selector-dialog.ts +++ b/projects/aca-testing-shared/src/components/dialog/content-node-selector-dialog.ts @@ -24,7 +24,7 @@ import { by, browser, protractor } from 'protractor'; import { GenericDialog } from '../dialog/generic-dialog'; -import { isPresentAndDisplayed, waitForStaleness, waitForPresence, isPresentAndEnabled } from '../../utilities/utils'; +import { waitForStaleness, waitForPresence } from '../../utilities/utils'; import { DropDownBreadcrumb } from '../breadcrumb/dropdown-breadcrumb'; import { DataTable } from '../data-table/data-table'; import { BrowserActions } from '@alfresco/adf-testing'; @@ -32,14 +32,12 @@ import { BrowserActions } from '@alfresco/adf-testing'; export class ContentNodeSelectorDialog extends GenericDialog { cancelButton = this.childElement(by.css('[data-automation-id="content-node-selector-actions-cancel"]')); copyButton = this.childElement(by.cssContainingText('[data-automation-id="content-node-selector-actions-choose"]', 'Copy')); - moveButton = this.childElement(by.cssContainingText('[data-automation-id="content-node-selector-actions-choose"]', 'Move')); locationDropDown = this.rootElem.element(by.id('site-dropdown-container')); locationPersonalFiles = browser.element(by.cssContainingText('.mat-option .mat-option-text', 'Personal Files')); locationFileLibraries = browser.element(by.cssContainingText('.mat-option .mat-option-text', 'My Libraries')); searchInput = this.rootElem.element(by.css('#searchInput')); - toolbarTitle = this.rootElem.element(by.css('.adf-toolbar-title')); breadcrumb = new DropDownBreadcrumb(); dataTable = new DataTable('.adf-content-node-selector-dialog'); @@ -74,25 +72,9 @@ export class ContentNodeSelectorDialog extends GenericDialog { await waitForPresence(browser.element(by.css('.adf-is-selected'))); } - async isSelectLocationDropdownDisplayed(): Promise { - return isPresentAndDisplayed(this.locationDropDown); - } - - async isCopyButtonEnabled(): Promise { - return isPresentAndEnabled(this.copyButton); - } - - async isCancelButtonEnabled(): Promise { - return isPresentAndEnabled(this.cancelButton); - } - async searchFor(text: string): Promise { await BrowserActions.clearWithBackSpace(this.searchInput); await this.searchInput.sendKeys(text); await this.searchInput.sendKeys(protractor.Key.ENTER); } - - async getToolbarTitle(): Promise { - return this.toolbarTitle.getText(); - } }