Skip to content
This repository has been archived by the owner on Apr 25, 2021. It is now read-only.

How to properly handle non-numerical media queries #4

Open
AlecAivazis opened this issue Oct 29, 2015 · 1 comment
Open

How to properly handle non-numerical media queries #4

AlecAivazis opened this issue Oct 29, 2015 · 1 comment
Labels

Comments

@AlecAivazis
Copy link
Owner

AlecAivazis commented Oct 29, 2015

Our current implementation gives browser.lessThan.landscape a false value which is not quite right. Maybe this is a good usecase for setting the value to undefined?

@icopp
Copy link

icopp commented Nov 3, 2017

For the project I'm currently working on, we've leaned heavily on leaving items undefined where possible (though Redux gets in the way of that somewhat) because (a) we're using react-redux and supplying everything as destructured props, and (b) we're using Typescript/ES6, so it's extremely easy to have inline defaults inside a component for undefined items from the Redux state (but not for null ones).

However, the "official" approach for Redux seems to be to set things null and never use undefined, to the point of it refusing to accept undefined values from normal reducers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants