Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the subsetting tool assumptions regarding 1:1 wb and cat designations #43

Open
jameshalgren opened this issue Apr 11, 2023 · 0 comments
Assignees

Comments

@jameshalgren
Copy link
Contributor

See comments here:

# As long as these remain 1-1 this works, but that may not always be the case
# FIXME in fact this isn't true at all, there can be catchments with no FP, and FP with no catchment

and here:

# Note
A current shortcut is being used to map `wb` and `cat` ids that isn't a valid assumption, and will be fixed in the future.
This means you might get a subset that isn't topologically consistent, so use at your own risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants