Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg.topic doesn't work as predefined sql queries #18

Open
iamgaborgithub opened this issue Apr 14, 2019 · 2 comments
Open

msg.topic doesn't work as predefined sql queries #18

iamgaborgithub opened this issue Apr 14, 2019 · 2 comments

Comments

@iamgaborgithub
Copy link
Contributor

Hi!

I find out that msg.topic is mentioned in the readMe of alasql node, but it isn't used in the code. A made a change on the code at my local. I changed in the readMe msg.topic to msg.query because msg.topic used bz several another nodes. And I changed the node-red-contrib-alasql.js line 9 from var sql = this.query || 'SELECT * FROM ?'; to var sql = this.query || msg.query || 'SELECT * FROM ?'; to use this variable. It works fine for me. Please let me know how can it be released?

Thank you very much, Gábor

@mathiasrw
Copy link
Member

Sounds interesting. Can you make a pull request?

@iamgaborgithub
Copy link
Contributor Author

Thank you very much for your responde. I created a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants