Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates in favorited locations #271

Open
PhilC813 opened this issue Dec 13, 2024 · 5 comments
Open

Duplicates in favorited locations #271

PhilC813 opened this issue Dec 13, 2024 · 5 comments

Comments

@PhilC813
Copy link

PhilC813 commented Dec 13, 2024

On the Android app, if I use the "Find GPS location button" option in the overflow menu, and then favorite the location, I can repeat these steps and favorite the same location over and over again, leading to duplicates in the favorites menu.

Screenshot_20241212_211035

Install source: Google Play
App version: 2.9.3 (latest)
Build: 146

Device: REDMAGIC 9 Pro
Android version: 14 (latest)

@PhilC813 PhilC813 changed the title Duplicates in favorite locations Duplicates in favorited locations Dec 13, 2024
@farfromrefug
Copy link
Collaborator

@PhilC813 dont think i will fix this. The favorite id is defined by its lat long. If you use the gps multiple times it might return different lat/lng. I cant know that those are actually the same. And users might want close locations (weather forecast might be different).
SO dont think i will fix it

@PhilC813
Copy link
Author

Oh okay I understand, but the UI really gives the impression that it's based on postal code. Most weather apps don't work this way. Could the coordinates be specified in the list instead?

@farfromrefug
Copy link
Collaborator

@PhilC813 good point Will add it

@PhilC813
Copy link
Author

Thank you!!

Also, have you seen this UI issue before? The one that you can see in my screenshot, with the top of the favorites sidebar cut off. It only happens with the favorites menu and maybe one or two other areas but can't recall where.

@farfromrefug
Copy link
Collaborator

@PhilC813 no i have not will try to reproduce to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants