Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #2

Open
1 task
ftisiot opened this issue Feb 16, 2022 · 3 comments
Open
1 task

Testing #2

ftisiot opened this issue Feb 16, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@ftisiot
Copy link
Collaborator

ftisiot commented Feb 16, 2022

What is currently missing?

As of now there's no testing apart from running the src/create_services.sh script, run the code, and check visually the output.
Some more testing is needed to validate changes

Is this a feature you would work on yourself?

  • I plan to open a pull request for this feature
@ftisiot ftisiot added the help wanted Extra attention is needed label Feb 16, 2022
@inifares23lab
Copy link
Contributor

Hi I started looking into some more little issues already (#25,#28,#56)
after those I would like to start on this.

Python is not my "mother toungue" 😅 and I never really wrote tests for a real project in python so I would like to practice here.

I was thinking of using pytest

@ftisiot
Copy link
Collaborator Author

ftisiot commented Oct 9, 2023

That would be amazing! @TibsAtWork any suggestions regarding pytest?

@TibsAtWork
Copy link
Contributor

I like pytest, so would think it's a good place to start.

I'd probably start by creating the tests directory and just writing that first test, choosing whatever looks not-too-hard to test. That alone would be a good contribution 😄

Writing tests can lead to fairly interactive PRs anyway (where the PR writer asks for opinions of the other contributors, and it goes around several cycles of review) so it makes good sense as a learning task.

Also, trying to write tests for a project that doesn't have them will often lead to refactoring the existing code to make it easier to test, so don't be afraid to raise issues that are like "this part of the code is hard to test, can we refactor it to make it do/not do XXX instead". Refactoring of this type is often a good way of making the code easier to understand as well.

Later on, there's the option of integrating it with the CI toolchain, but initially just having testing set up at all would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants