Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output of yarn start:contract is disorganized, not checked #62

Open
dckc opened this issue Jan 25, 2024 · 2 comments
Open

output of yarn start:contract is disorganized, not checked #62

dckc opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dckc
Copy link
Member

dckc commented Jan 25, 2024

For steps like voting, the output should be concise: timestamp, block height, hash, proposal number, YES should fit on one line.

using json-lines uniformly can be a big help.

@dckc
Copy link
Member Author

dckc commented Jan 9, 2025

@amessbee nice work on #27! The logs of the first part of start:contract are so much nicer...

Run yarn start:contract
Waiting for blockchain to start...
..............................................................................................
agd-1  | 2025-01-09T11:03:[4](https://github.com/Agoric/dapp-offer-up/actions/runs/12688514812/job/35365216310#step:8:5)5.545Z block-manager: block 1227 commit
Blockchain is running and producing blocks...

If you have more time/energy for this sort of thing, it would be great to get the rest of the logs cleaned up, as noted in this issue.
Using the dots technique in more places would be cool... we could use a pattern from npm / yarn:

  1. put the whole noisy log in a temp file.
    • perhaps prepend a timestamp to each line
  2. yarn shows a spinner for progress; we can do a dot for every line of logs, as above
  3. If things succeed, just print a summary of the results (last log line? contract name?)
  4. If things fail, print something like FAILED to start:contract. see log file /tmp/log234235.
    • Maybe suggest yarn docker:logs as well.

I suppose detecting whether things succeed or fail could be a lot of work; as noted above, the results of several of the steps are just not checked. We could just do here what our ci job does: do a vstorage query for the contract name in published.agoricNames.instance.

@amessbee
Copy link
Contributor

Sounds like a plan. I am going to assign it to myself to get it to when I can without any deadlines in mind if that's okay.

@amessbee amessbee self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants