Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas price not updated unless it's higher #11

Open
JonathonDunford opened this issue Mar 27, 2018 · 0 comments
Open

Gas price not updated unless it's higher #11

JonathonDunford opened this issue Mar 27, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@JonathonDunford
Copy link
Member

Issue by freeatnet
Sunday Jan 14, 2018 at 12:32 GMT
Originally opened as https://github.com/forkdelta/forkdelta.github.io/issues/17

  1. Visit ForkDelta while gas price is high
  2. Wait for gas prices to drop and ForkDelta to reduce gas price
  3. Visit ForkDelta again

Expected: default gas price is reduced accordingly.
Observed: gas price is still at old default

Caused by newEthGasPrice > self.config.ethGasPrice in main.js logic of gas price updates.

Suggested:

  • Differentiate between user-set gas price and default gas price.
  • Use the higher of (default gas price, user-set gas price).
@JonathonDunford JonathonDunford added the bug Something isn't working label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonathonDunford