Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to classify code review #5

Open
maybeec opened this issue Oct 27, 2014 · 1 comment
Open

Ability to classify code review #5

maybeec opened this issue Oct 27, 2014 · 1 comment
Milestone

Comments

@maybeec
Copy link
Member

maybeec commented Oct 27, 2014

Created by "sudr":

When I'm providing code reviews, I like to include why I'm suggesting the change. Some common reasons that I've used to suggest a code change are:

  1. More readable code
  2. Code style
  3. Tell don't ask principle
  4. Code cleanup
  5. DRY principle

Some of these, like the "More readable code", I use more often than others. Right now I include this as part of the Description field in Comment Details. Instead it would be nice to be able to enter this as a separate field called "Reason". I'm thinking a ComboBox with the more common reasons already present in the dropdown with the ability for the user to enter a custom value.

@maybeec maybeec added this to the v0.9.1 milestone Oct 27, 2014
@maybeec
Copy link
Member Author

maybeec commented Oct 27, 2014

commented by "paraglohiya":

More example of Problem Categories
Good link for category is - http://sourcemaking.com/refactoring [^]
This can be taken as xml input where enterprise can define there own categories
xml format can be

<categories>
<category>
 <parent><parent> e.g. General, Performance, Naming, Available,
 <type></type> e.g. Duplicated Code, Bad Method Name, Dead Code, Large Method, Too Many Method Parameters
 <description></description>
</category>
<categories>
  • Duplicated Code
  • Bad Method Name
  • Dead Code
  • Large Method
  • Too Many Method Parameters
  • Missed Standard
  • Inappropriate Intimacy
  • Feature Envy
  • Lazy Class
  • Positive Comment
  • Question

@postmann postmann modified the milestones: 1.0, 0.9.1 Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants