Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophes in Scheme Names Cause Problems #104

Open
as2388 opened this issue Nov 1, 2017 · 2 comments
Open

Apostrophes in Scheme Names Cause Problems #104

as2388 opened this issue Nov 1, 2017 · 2 comments
Assignees
Labels

Comments

@as2388
Copy link
Member

as2388 commented Nov 1, 2017

At the moment it is possible to put an apostrophe in the name of a code scheme. However, this causes the name to fail to display in the table headers.

We should prevent apostrophes in the code scheme editor, and/or escape them when rendering the headers.

@lukechurch
Copy link
Member

@pmishkin

@as2388
Copy link
Member Author

as2388 commented Nov 21, 2017

Coda is now giving me errors when I type an apostrophe into the editor.

Not sure how I triggered this error before - perhaps it was by editing the scheme file directly (in which case, FileUtils.loadCodeScheme needs to perform the same validation as the editor save button).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants