Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COIOS-806: Support all Boleto Bancario tx-variants #1903

Merged
merged 14 commits into from
Nov 26, 2024

Conversation

nauaros
Copy link
Contributor

@nauaros nauaros commented Nov 20, 2024

Summary

Add support for the following Boleto tx-variants:

  • Boleto Bancario Itaú (boletoBancarioItau)
  • PrimeiroPay Boleto (boletoBancarioItau)
  • Boleto Bancario (boletoBancario)

Ticket

COIOS-806

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@nauaros nauaros added the new a pull request that adds a new feature label Nov 20, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 20, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 20, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 20, 2024
descorp
descorp previously approved these changes Nov 20, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 22, 2024
@nauaros nauaros changed the title COIOS-806: Support all boleto bancario tx-variants COIOS-806: Support all Boleto Bancario tx-variants Nov 22, 2024
@nauaros nauaros marked this pull request as ready for review November 22, 2024 12:52
Robert-SD
Robert-SD previously approved these changes Nov 22, 2024
Copy link
Contributor

@erenbesel erenbesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a tiny comment on deprecation message

Copy link
Contributor

👀 11 public changes detected

Comparing COIOS-806_Support_boleto_bancario_variant to develop


Adyen

PaymentMethodType

❇️ Added

case boletoBancario
case boletoBancarioItau
case boletoBancarioSantander
case primeiroPayBoleto

🔀 Changed

// From
case boleto

// To
@available(*, deprecated, renamed: "boletoBancarioSantander", message: "Use 'boletoBancarioSantander' instead. Consider 'boletoBancario' as the default payment method for Boleto Bancario.") case boleto

/**
Changes:
- Added attribute `@available(*, deprecated, renamed: "boletoBancarioSantander", message: "Use 'boletoBancarioSantander' instead. Consider 'boletoBancario' as the default payment method for Boleto Bancario.")`
*/

AdyenActions

VoucherAction

❇️ Added

case boletoBancario(AdyenActions.BoletoVoucherAction)
case boletoBancarioItau(AdyenActions.BoletoVoucherAction)
case primeiroPayBoleto(AdyenActions.BoletoVoucherAction)

VoucherPaymentMethod

❇️ Added

case boletoBancario
case boletoBancarioItau
case primeiroPayBoleto

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

Copy link

sonarcloud bot commented Nov 25, 2024

@nauaros nauaros merged commit 0a00fa0 into develop Nov 26, 2024
13 checks passed
@nauaros nauaros deleted the COIOS-806_Support_boleto_bancario_variant branch November 26, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new a pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants