Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COIOS-774: Pay by Bank #1878

Merged
merged 16 commits into from
Nov 25, 2024
Merged

COIOS-774: Pay by Bank #1878

merged 16 commits into from
Nov 25, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Oct 24, 2024

Summary

  • Adds support for additional information when showing a stored pay by bank payment method

Demo

image

Release notes

  • Pay by Bank in the US now supports stored payment methods.
  • For Pay by Bank in the US, when you use PaymentMethodType.paybybank_AIS_DD, Drop-in now show the logos of the supported banks and a confirmation screen before redirecting to the issuer

Ticket

COIOS-774

<!-- 🎉 Thank you for submitting a pull request! 🎉  -->

## Summary
- Adds support for additional information when showing a stored pay by
bank payment method


![image](https://github.com/user-attachments/assets/8d099b0e-1a87-485c-89f8-28abe8632bc1)

<ticket>COIOS-774</ticket>

---------

Co-authored-by: Alex Guretzki <[email protected]>
@goergisn goergisn changed the title COIOS-774: Pay by Bank - Base COIOS-774: Pay by Bank - [Base] Oct 24, 2024
@goergisn goergisn added the new a pull request that adds a new feature label Oct 24, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 24, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 8, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 8, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 8, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 14, 2024
@goergisn goergisn changed the title COIOS-774: Pay by Bank - [Base] COIOS-774: Pay by Bank Nov 18, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 19, 2024
@goergisn goergisn marked this pull request as ready for review November 19, 2024 15:44
erenbesel
erenbesel previously approved these changes Nov 20, 2024
nauaros
nauaros previously approved these changes Nov 22, 2024
Copy link
Contributor

👀 4 public changes detected

Comparing COIOS-774_pay-by-bank-improvements to develop


Adyen

❇️ Added

public struct PayByBankUSPaymentMethod: Adyen.PaymentMethod
{
  public let type: Adyen.PaymentMethodType { get }
  public var name: Swift.String
  public var merchantProvidedDisplayInformation: Adyen.MerchantCustomDisplayInformation?
  public func defaultDisplayInformation(using parameters: Adyen.LocalizationParameters?) -> Adyen.DisplayInformation
  public func encode(to encoder: any Swift.Encoder) throws -> Swift.Void
  public init(from decoder: any Swift.Decoder) throws
}
public struct StoredPayByBankUSPaymentMethod: Adyen.StoredPaymentMethod
{
  public let type: Adyen.PaymentMethodType { get }
  public let name: Swift.String { get }
  public let label: Swift.String? { get }
  public var merchantProvidedDisplayInformation: Adyen.MerchantCustomDisplayInformation?
  public let identifier: Swift.String { get }
  public let supportedShopperInteractions: [Adyen.ShopperInteraction] { get }
  public func encode(to encoder: any Swift.Encoder) throws -> Swift.Void
  public init(from decoder: any Swift.Decoder) throws
}

PaymentMethodType

❇️ Added

case payByBankAISDD

AdyenComponents

❇️ Added

final public class PayByBankUSComponent: Adyen.PaymentComponent, Adyen.PresentableComponent, Adyen.LoadingComponent
{
  final public let paymentMethod: any Adyen.PaymentMethod { get }
  final public var paymentData: Adyen.PaymentComponentData { get }
  final public var configuration: AdyenComponents.PayByBankUSComponent.Configuration
  weak final public var delegate: (any Adyen.PaymentComponentDelegate)?
  final public var requiresModalPresentation: Swift.Bool
  final public var viewController: UIKit.UIViewController { get }
  public init(paymentMethod: Adyen.PayByBankUSPaymentMethod, context: Adyen.AdyenContext, configuration: AdyenComponents.PayByBankUSComponent.Configuration = .init())
  final public func initiatePayment() -> Swift.Void
  public struct Configuration: Adyen.AnyBasicComponentConfiguration
  {
      public var style: AdyenComponents.PayByBankUSComponent.Style
      public var localizationParameters: Adyen.LocalizationParameters?
      public init(style: AdyenComponents.PayByBankUSComponent.Style = .init(), localizationParameters: Adyen.LocalizationParameters? = nil)
  }
  public struct Style
  {
      public var title: Adyen.TextStyle
      public var subtitle: Adyen.TextStyle
      public var message: Adyen.TextStyle
      public var headerImage: Adyen.ImageStyle
      public var submitButton: Adyen.ButtonStyle
      public init()
  }
  final public func stopLoading() -> Swift.Void
}

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

Copy link

sonarcloud bot commented Nov 25, 2024

@goergisn goergisn merged commit adb4adf into develop Nov 25, 2024
13 checks passed
@goergisn goergisn deleted the COIOS-774_pay-by-bank-improvements branch November 25, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new a pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants