COIOS-774: Pay by Bank - Confirmation Sheet #1876

goergisn · 2024-10-23T09:58:42Z

Summary

Adds a confirmation sheet in front of SFSafariViewController and triggers the instant payment method only after triggering the submit button

Demo

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-23.at.11.57.04.mp4

Ticket

COIOS-774

…by-bank-ui-update

AdyenComponents/PayByBank/US/PayByBankUSComponent+ConfirmationViewController.swift

atmamont · 2024-10-25T08:19:33Z

AdyenComponents/PayByBank/US/PayByBankUSComponent+ConfirmationViewController.swift

+            contentButtonStack.alignment = .fill
+
+            view.addSubview(contentButtonStack)
+            contentButtonStack.adyen.anchor(inside: view.layoutMarginsGuide, with: .init(top: 16, left: 0, bottom: 8, right: 0))


Ideally this should go to some style constants in the future to avoid these magic numbers and make style changes easier.

atmamont · 2024-10-25T08:20:21Z

AdyenComponents/PayByBank/US/PayByBankUSComponent+ConfirmationViewController.swift

+            model.continueHandler()
+        }
+
+        override public var preferredContentSize: CGSize {


What happens if we don't provide this manually?

it will not get the height it needs

atmamont · 2024-10-25T08:20:50Z

AdyenComponents/PayByBank/US/PayByBankUSComponent+ConfirmationViewController.swift

+            style: PayByBankUSComponent.Style,
+            continueHandler: @escaping () -> Void
+        ) {
+            let message: [String] = [


Should this be localized?

Good catch 😬

atmamont · 2024-10-25T08:21:10Z

AdyenComponents/PayByBank/US/PayByBankUSComponent+ConfirmationViewController.swift

+            ]
+
+            self.headerImageUrl = headerImageUrl
+            self.title = "Pay by Bank"


Same here and further down

atmamont · 2024-10-25T08:23:24Z

AdyenDropIn/Utilities/ComponentManager+PaymentComponentBuilder.swift

@@ -419,7 +433,7 @@ extension ComponentManager: PaymentComponentBuilder {
        )
    }

-    private func createBoletoComponent(_ paymentMethod: BoletoPaymentMethod) -> BoletoComponent {
+    func createBoletoComponent(_ paymentMethod: BoletoPaymentMethod) -> BoletoComponent {


We have a linter rule to prevent us from NOT having a scope defined, right?

It does not catch here for some reason - it's in a private extension

Maybe we can turn swiftlint warnings into errors so every time one doesn't need to even focus on this during code review.

atmamont

Easy to read and review, thanks 👍

atmamont · 2024-10-25T08:43:59Z

Adyen/Core/Payment Methods/StoredPayByBankUSPaymentMethod.swift

-/// Stored PayByBank payment.
-public struct StoredPayByBankPlaidPaymentMethod: StoredPaymentMethod {
+/// Stored PayByBank US payment.
+public struct StoredPayByBankUSPaymentMethod: StoredPaymentMethod {


⚠️ This is a fully breaking change, can we keep struct and maybe create a typealias?

I found StoredPayByBankPlaidPaymentMethod was added in the base branch. Let's rethink which branch to target when we run api diff? Options:

develop (then we might have all long-living branch changes)

latest release tag (then every time we have all development changes combined)

Or we can switch off api diff for all PRs not targeting develop and deal with all changes when we merge long-living branch into develop. The only concern I have is that usually it's a common sentiment to merge as fast as possible because "everything was reviewed", everyone has seen the code multiple times and naturally you just want to merge it asap.

Yeah that's a tricky one - also thought about it.
I want to see the changes to the target branch but also agree that it would be nice to see the full change set to develop/release.
We could run it twice if the target branch is not develop and we're not in a release branch - so it creates 2 comments (one to the target branch and one to develop) - 🤔

Adyen/Core/Payment Methods/PayByBankUSPaymentMethod.swift

Adyen/Core/Payment Methods/StoredPayByBankUSPaymentMethod.swift

github-actions · 2024-10-28T11:21:12Z

👀 6 public changes detected

Comparing https://github.com/Adyen/adyen-ios.git @ COIOS-774_pay-by-bank-ui-update to https://github.com/Adyen/adyen-ios.git @ COIOS-774_pay-by-bank-improvements

`Adyen`

❇️ Added

public struct PayByBankUSPaymentMethod: Adyen.PaymentMethod
{
  public let type: Adyen.PaymentMethodType { get }
  public var name: Swift.String
  public var merchantProvidedDisplayInformation: Adyen.MerchantCustomDisplayInformation?
  public func encode(to encoder: any Swift.Encoder) throws -> Swift.Void
  public init(from decoder: any Swift.Decoder) throws
}

public struct StoredPayByBankUSPaymentMethod: Adyen.StoredPaymentMethod
{
  public let type: Adyen.PaymentMethodType { get }
  public let name: Swift.String { get }
  public let label: Swift.String? { get }
  public var merchantProvidedDisplayInformation: Adyen.MerchantCustomDisplayInformation?
  public let identifier: Swift.String { get }
  public let supportedShopperInteractions: [Adyen.ShopperInteraction] { get }
  public func encode(to encoder: any Swift.Encoder) throws -> Swift.Void
  public init(from decoder: any Swift.Decoder) throws
}

😶‍🌫️ Removed

public struct StoredPayByBankPlaidPaymentMethod: Adyen.StoredPaymentMethod

`PaymentMethodType`

❇️ Added

case payByBankAISDD

😶‍🌫️ Removed

case payByBankPlaid

`AdyenComponents`

❇️ Added

final public class PayByBankUSComponent: Adyen.PaymentComponent, Adyen.PresentableComponent, Adyen.LoadingComponent
{
  final public let paymentMethod: any Adyen.PaymentMethod { get }
  final public var paymentData: Adyen.PaymentComponentData { get }
  final public var configuration: AdyenComponents.PayByBankUSComponent.Configuration
  weak final public var delegate: (any Adyen.PaymentComponentDelegate)?
  final public var requiresModalPresentation: Swift.Bool
  final public var viewController: UIKit.UIViewController { get }
  public init(paymentMethod: Adyen.PayByBankUSPaymentMethod, context: Adyen.AdyenContext, configuration: AdyenComponents.PayByBankUSComponent.Configuration = .init())
  final public func initiatePayment() -> Swift.Void
  public struct Configuration: Adyen.AnyBasicComponentConfiguration
  {
      public var style: AdyenComponents.PayByBankUSComponent.Style
      public var localizationParameters: Adyen.LocalizationParameters?
      public init(style: AdyenComponents.PayByBankUSComponent.Style = .init(), localizationParameters: Adyen.LocalizationParameters? = nil)
  }
  public struct Style
  {
      public var title: Adyen.TextStyle
      public var subtitle: Adyen.TextStyle
      public var message: Adyen.TextStyle
      public var headerImage: Adyen.ImageStyle
      public init()
  }
  final public func stopLoading() -> Swift.Void
}

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

sonarcloud · 2024-10-28T11:39:26Z

Quality Gate failed

Failed conditions
7.5% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Starting implementation of confirmation sheet

1ab9f14

goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Oct 23, 2024

Alex Guretzki added 2 commits October 23, 2024 12:02

Small fixes

36eca3c

Fixing font size

b4610ce

goergisn changed the title ~~COIOS-774 - Pay by Bank - Confirmation Sheet~~ COIOS-774: Pay by Bank - Confirmation Sheet Oct 23, 2024

Base automatically changed from better-stored-paybybank-plaid-support to COIOS-774_pay-by-bank-improvements October 24, 2024 08:49

erenbesel approved these changes Oct 24, 2024

View reviewed changes

goergisn requested review from nauaros and atmamont October 24, 2024 11:18

Merge branch 'COIOS-774_pay-by-bank-improvements' into COIOS-774_pay-…

f71dfad

…by-bank-ui-update

github-actions bot approved these changes Oct 24, 2024

View reviewed changes

Alex Guretzki added 2 commits October 24, 2024 13:29

Fixing SPM tests

4badfff

fixing imports

881c629

atmamont reviewed Oct 25, 2024

View reviewed changes

AdyenComponents/PayByBank/US/PayByBankUSComponent+ConfirmationViewController.swift Show resolved Hide resolved

atmamont reviewed Oct 25, 2024

View reviewed changes

atmamont approved these changes Oct 25, 2024

View reviewed changes

atmamont reviewed Oct 25, 2024

View reviewed changes

nauaros reviewed Oct 25, 2024

View reviewed changes

Adyen/Core/Payment Methods/PayByBankUSPaymentMethod.swift Outdated Show resolved Hide resolved

Adyen/Core/Payment Methods/StoredPayByBankUSPaymentMethod.swift Outdated Show resolved Hide resolved

Alex Guretzki added 2 commits October 28, 2024 11:20

Some refactoring

d1b9bc1

Adding padding constants

342953a

goergisn merged commit dc5436c into COIOS-774_pay-by-bank-improvements Oct 28, 2024
10 of 11 checks passed

goergisn deleted the COIOS-774_pay-by-bank-ui-update branch October 28, 2024 19:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COIOS-774: Pay by Bank - Confirmation Sheet #1876

COIOS-774: Pay by Bank - Confirmation Sheet #1876

goergisn commented Oct 23, 2024

atmamont Oct 25, 2024

atmamont Oct 25, 2024

goergisn Oct 28, 2024 •

edited

Loading

atmamont Oct 25, 2024

goergisn Oct 25, 2024

atmamont Oct 25, 2024

atmamont Oct 25, 2024

goergisn Oct 28, 2024

atmamont Oct 28, 2024

atmamont left a comment

atmamont Oct 25, 2024

atmamont Oct 25, 2024

goergisn Oct 28, 2024

github-actions bot commented Oct 28, 2024

sonarcloud bot commented Oct 28, 2024

COIOS-774: Pay by Bank - Confirmation Sheet #1876

COIOS-774: Pay by Bank - Confirmation Sheet #1876

Conversation

goergisn commented Oct 23, 2024

Summary

Demo

Ticket

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goergisn Oct 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atmamont left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 28, 2024

👀 6 public changes detected

Adyen

❇️ Added

😶‍🌫️ Removed

PaymentMethodType

❇️ Added

😶‍🌫️ Removed

AdyenComponents

❇️ Added

sonarcloud bot commented Oct 28, 2024

Quality Gate failed

goergisn Oct 28, 2024 •

edited

Loading

`Adyen`

`PaymentMethodType`

`AdyenComponents`