From e72558be5cf6c58b5817f168a9141a2ed68187f8 Mon Sep 17 00:00:00 2001 From: Oscar Spruit Date: Thu, 23 May 2024 15:28:43 +0200 Subject: [PATCH 1/2] Update sonar --- dependencies.gradle | 2 +- gradle/verification-metadata.xml | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/dependencies.gradle b/dependencies.gradle index 0ff97b11a0..56962668d7 100644 --- a/dependencies.gradle +++ b/dependencies.gradle @@ -31,7 +31,7 @@ ext { detekt_version = "1.23.6" jacoco_version = '0.8.12' ktlint_version = '1.2.1' - sonarqube_version = '4.4.1.3373' + sonarqube_version = '5.0.0.4638' // Android Dependencies annotation_version = "1.7.1" diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml index cf135a92b5..625c02a654 100644 --- a/gradle/verification-metadata.xml +++ b/gradle/verification-metadata.xml @@ -9730,6 +9730,11 @@ + + + + + @@ -9756,6 +9761,14 @@ + + + + + + + + From f7700739633dadc7378a003fb13663fd422d6a80 Mon Sep 17 00:00:00 2001 From: Oscar Spruit Date: Thu, 23 May 2024 15:43:49 +0200 Subject: [PATCH 2/2] Split sonar command This makes sure sonar runs after the other tasks are completed --- .github/workflows/sonar_cloud.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonar_cloud.yml b/.github/workflows/sonar_cloud.yml index 9974c6f56c..9d744b7798 100644 --- a/.github/workflows/sonar_cloud.yml +++ b/.github/workflows/sonar_cloud.yml @@ -35,4 +35,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - run: ./gradlew detekt assDeb jacocoDebugTestReport lintDeb sonar -Dsonar.gradle.skipCompile=true -Pstrip-resources=true + run: | + ./gradlew detekt assDeb jacocoDebugTestReport lintDeb -Pstrip-resources=true + ./gradlew sonar