Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning timestamp incorrect in Homey #40

Open
EricMuhren opened this issue Jul 22, 2024 · 14 comments
Open

Lightning timestamp incorrect in Homey #40

EricMuhren opened this issue Jul 22, 2024 · 14 comments

Comments

@EricMuhren
Copy link

Hi,

Very nice app! In Homey the timestamp of lightnings is one hour early. The time and date in the hub are correct. Is there a possibility to set an offset? Or another solution?

Thanks in advance.

@AdyRock
Copy link
Owner

AdyRock commented Jul 22, 2024

Hmm, I'm not sure why. The time of my last strike reads the same in Homey and WS View. I can't say for sure if that was the correct time as it was 4 days ago and I didn't look then.
The app should adjust the UTC time to the same time zone as Homey, so is homey set to the correct region?

@EricMuhren
Copy link
Author

EricMuhren commented Jul 23, 2024

Hi,

Today thunder again! I'll show you the screenshots.

_GW1100C
_Homey

@AdyRock
Copy link
Owner

AdyRock commented Jul 23, 2024

Do you know for sure which one is correct for your time zone?

@EricMuhren
Copy link
Author

The GW1100C is the correct one. Screenshots of Homey an WC1100C you can see timezones and times are the same.
Perhaps you can create an offset parameter (+-hours) and add or substract it before showing it to Homey. Then the insights will be correct as well. Or you are able to find the root cause....
_Homey_1
_GW1100C_1

@AdyRock
Copy link
Owner

AdyRock commented Jul 23, 2024

I have a feeling that both the bridge and Homey are adjusting the time.
I will add an option to switch off the adjustment in the device advanced settings.

@EricMuhren
Copy link
Author

That would be nice!

@AdyRock
Copy link
Owner

AdyRock commented Jul 25, 2024

Should be in the test version in the store.

@EricMuhren
Copy link
Author

Thanks. I still have to wait for a thunderstorm to check.

@EricMuhren
Copy link
Author

EricMuhren commented Aug 13, 2024

The datetime stamp in GW1100C is correct.

With new option set to no the difference is -2 hours. With option set to yes the difference is -1 hour.

@AdyRock
Copy link
Owner

AdyRock commented Aug 23, 2024

Could you set the time format in the advanced settings to Time Stamp and the Adjust Time to No, then let me know what time is shown in the Homey device and what time is shown in WS View.
Then set the Adjust Time to Yes and let me know the Homey device time.

For me the time reported by the API (Time Stamp and the Adjust Time to No) is GMT 2024-08-21T00:05:29.000Z, while WS View is showing BST, 2024-08-21T01:05:29.000Z. If I set the Adjust time to Yes then both show BST.

What is your local time offset from GMT?
Do your clocks adjust for summer time?

@EricMuhren
Copy link
Author

Hi,

Time Stamp No
TimeStampNo

Time Stamp Yes
TimeStampYes

Time Stamp WS
TimeStampWS

Amsterdam = GMT + 1
Clocks are adjusted for summer time. (DST)

@AdyRock
Copy link
Owner

AdyRock commented Aug 25, 2024

So just to make sure I understand, your current time is GMT + 2?

In which case it seems the API is returning GMT as expect but the app is not adjusting for your timezone.
The new option is switching off the summer time adjustments and that seems to be working as expected.

I am going to add a new log message to show what is being returned by Homey for the timezone value the app uses and I will let you know when that is ready.

@EricMuhren
Copy link
Author

EricMuhren commented Aug 25, 2024

Yes, you're right. Timezone at this moment is GMT+2. Plus 1 in winter, plus 2 in summer.

Are insights working correct after you've implemented your changes?

@AdyRock
Copy link
Owner

AdyRock commented Aug 25, 2024

I have published a test version that logs the timezone and language reported by Homey. That's the data I use in the time conversion, so would be interested to see what you have set.

Which insights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants