Added new social media sharing button #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b01690.
wei2912
requested changes
Jan 7, 2022
There was a problem hiding this comment.
A few minor comments on the styling (please refer to the following image):
- Colour of Facebook icon does not match the text.
- LinkedIn icon placement is slightly off, and the sizing of all icons is not consistent.
Think you'll want to edit the icons with a SVG editor.
partials/content.hbs
Outdated
| <svg class="icon icon-twitter"> | ||
| <use xlink:href="#twitter"></use> | ||
| </svg> | ||
| <use xlink:href="#twitter"></use> |
There was a problem hiding this comment.
Seems like extra indentation was added here, please revert back to the indentation of the other icons!
partials/content.hbs
Outdated
Comment on lines
20
to
36
| {{#has tag="count:>1"}} | ||
| <div> | ||
| <span class="tag-list-label">More:</span> | ||
| {{#if primary_tag}} | ||
| {{#foreach tags}} | ||
| {{#if @first}} | ||
| {{else}} | ||
| <a class="tag-list-item font-semibold" href="{{url}}">{{name}}</a> | ||
| {{/if}} | ||
| {{/foreach}} | ||
| {{else}} | ||
| {{#foreach tags}} | ||
| <a class="tag-list-item font-semibold" href="{{url}}">{{name}}</a> | ||
| {{/foreach}} | ||
| {{/if}} | ||
| </div> | ||
| {{/has}} |
There was a problem hiding this comment.
Please undo the deletion of these lines.
partials/content.hbs
Outdated
| </div> | ||
| {{/is}} | ||
| <h1 class="single-title">{{title}}</h1> | ||
| <h1 class="single-title" id="title">{{title}}</h1> |
There was a problem hiding this comment.
This id seems quite generic, could we remove it here?
|
Merged in 6480ef5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.