Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPT-59] & [GPT-61]: Change styling of tags #306

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jeffzy15
Copy link
Contributor

Centered the tags on the featured articles

image

@wei2912 wei2912 requested review from a team and Hackin7 and removed request for a team November 18, 2023 08:45
@wei2912 wei2912 linked an issue Nov 18, 2023 that may be closed by this pull request
@Hackin7
Copy link
Contributor

Hackin7 commented Nov 20, 2023

Comparison with the previous design to figure out which is better for info, this probably needs more discussion on which design is more ideal.
I'm also a bit iffy on the text overflow of this PR, but this also needs more discussion

old examples
image

image image

new
image

image image

@Hackin7
Copy link
Contributor

Hackin7 commented Nov 22, 2023

if there's a post with only 1 tag, make it left justify

@jeffzy15
Copy link
Contributor Author

jeffzy15 commented Nov 24, 2023

Added commits for #314

@jeffzy15 jeffzy15 changed the title [GPT-59] Center the Tags on the featured articles [GPT-59] & [GPT-61]: Change styling of tags Nov 24, 2023
@Hackin7
Copy link
Contributor

Hackin7 commented Dec 5, 2023

This is linked to #315
The code right now might be a bit buggy but I think it does what needs to be done, which is center the tags

@Hackin7
Copy link
Contributor

Hackin7 commented Dec 6, 2023

Related Commits

  1. [GPT-61] Maximum width of tag #314
  2. [GPT-62] Experiment with Switching Position of Title and tags #315
  3. [GPT-59] Center the Tags on the featured articles #303

It appears that text cutoff was not implemented yet

image

Sometimes the 1 lag left align thing works, and sometimes it doesn't work

image image

@Hackin7
Copy link
Contributor

Hackin7 commented Jan 15, 2024

This task is a handful to handle and it is not super urgent so for now this is to be put on hold until we have better confirmation about the direction of the website from a committee

@wei2912 wei2912 marked this pull request as draft February 18, 2024 14:50
@wei2912
Copy link
Member

wei2912 commented Feb 18, 2024

Converted this issue to draft - note conflicts need to be resolved too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GPT-59] Center the Tags on the featured articles
3 participants