Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove offline instrumentation with Jacoco #3494

Closed
kwin opened this issue Dec 14, 2024 · 0 comments · Fixed by #3495
Closed

Remove offline instrumentation with Jacoco #3494

kwin opened this issue Dec 14, 2024 · 0 comments · Fixed by #3495

Comments

@kwin
Copy link
Contributor

kwin commented Dec 14, 2024

The Jacoco offline instrumentation modifies the generated bundle and its underlying manifest, leading potentially to false-positives with aemanalyze-maven-plugin and potentially other exceptions during the build (ClassNotFoundExceptions....). It has been introduced with 7cb5929 to ensure compatibility with PowerMocks (#1321). However this library is no longer used, therefore this workaround for coverage calculation is no longer necessary.

kwin added a commit that referenced this issue Dec 16, 2024
It incorrectly affects manifest calculation which leads to follow-up
issues with aemanalyser-m-p and is generally not recommended
(https://www.eclemma.org/jacoco/trunk/doc/instrument-mojo.html)

It was originally introduced for compatibility with PowerMock but that
is no longer used.

This closes #3494
kwin added a commit that referenced this issue Dec 16, 2024
It incorrectly affects manifest calculation which leads to follow-up
issues with aemanalyser-m-p and is generally not recommended
(https://www.eclemma.org/jacoco/trunk/doc/instrument-mojo.html)

It was originally introduced for compatibility with PowerMock but that
is no longer used.

Properly merge coverage from both UTs/ITs.

This closes #3494
kwin added a commit that referenced this issue Jan 2, 2025
It incorrectly affects manifest calculation which leads to follow-up
issues with aemanalyser-m-p and is generally not recommended
(https://www.eclemma.org/jacoco/trunk/doc/instrument-mojo.html)

It was originally introduced for compatibility with PowerMock but that
is no longer used.

Use a common execution data file for IT/UT as it is written to in append
mode by default (jacoco/jacoco#1676)

This closes #3494
@kwin kwin closed this as completed in #3495 Jan 2, 2025
@kwin kwin closed this as completed in e9bc657 Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant