Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edns-addr breaks caching (again) #414

Open
timkgh opened this issue Aug 22, 2024 · 1 comment
Open

edns-addr breaks caching (again) #414

timkgh opened this issue Aug 22, 2024 · 1 comment

Comments

@timkgh
Copy link

timkgh commented Aug 22, 2024

Same as the previous bug: #329

Looks like the bug is back again. If I remove edns-addr from dnsproxy.yaml caching works.

@timkgh
Copy link
Author

timkgh commented Aug 22, 2024

🤔 it may actually be a problem with the upstream DNS server and ECS. Should this response be cached?

2024/08/21 21:50:55.357266 DEBUG ecs does not match prefix=dnsproxy prefix=cache ecs=192.73.252.198/32 req_ecs=66.60.200.0/24

Can dnsproxy just cache if a static edns-addr is set in its options regardless of what the upstream returns? If edns-addr is set everything should be cachable, e.g. when running on a home router. This should probably be the default behavior or add a setting ignore ECS in responses and just cache, though setting edns-addr should imply such an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant