Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @@ rules to not disable cosmetics #70

Open
ameshkov opened this issue Dec 16, 2024 · 0 comments
Open

Improve @@ rules to not disable cosmetics #70

ameshkov opened this issue Dec 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ameshkov
Copy link
Member

Exception rules in Safari rely on the rule type ignore-previous-rules so to make it work we have to order the rules in a specific order. Exception rules without modifiers are placed at the end of the list and therefore they disable not just URL blocking, but cosmetic rules as well.

We could solve this by limiting resource-type list for those rules.

However, this will increase the list size and complexity so before doing that we should weigh pros and cons. How much bigger the final list will be?

@ameshkov ameshkov added the enhancement New feature or request label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant