Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve $genericblock implementation #69

Open
ameshkov opened this issue Dec 16, 2024 · 0 comments
Open

Improve $genericblock implementation #69

ameshkov opened this issue Dec 16, 2024 · 0 comments
Labels
enhancement New feature or request Priority: P4

Comments

@ameshkov
Copy link
Member

ameshkov commented Dec 16, 2024

In the current implementation $genericblock is basically the same as $document, i.e. it disables filtering completely.

This implementation can be improved if we change the way the list is ordered.

Here's how the rules should be ordered:

  1. Generic css-display-none rules
  2. $generichide ignore-previous-rules
  3. Generic url blocking rules
  4. $genericblock ignore-previous-rules
  5. Domain-specific css-display-none rules
  6. $elemhide ignore-previous-rules
  7. Domain-specific url blocking rules
  8. $urlblock ignore-previous-rules

In addition to that $genericblock rules' resource-types should be limited and exclude document. In this case it will not cover cosmetic rules.

@ameshkov ameshkov added the enhancement New feature or request label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: P4
Projects
None yet
Development

No branches or pull requests

2 participants