Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KADHosts #39

Closed
antek821 opened this issue May 27, 2022 · 9 comments
Closed

KADHosts #39

antek821 opened this issue May 27, 2022 · 9 comments
Labels
in progress The request is accepted, but it requires some additional work on our side

Comments

@antek821
Copy link

antek821 commented May 27, 2022

Could you please add the KADHosts list:
https://raw.githubusercontent.com/FiltersHeroes/KADhosts/master/KADhosts.txt
(homepage: https://github.com/FiltersHeroes/KADhosts)

which is the hosts version of the list:
https://github.com/AdguardTeam/FiltersRegistry/tree/master/filters/ThirdParty/filter_232_KADPrzekrety

@DandelionSprout
Copy link
Member

At a surface glance, the list seems considerably better than "Polish filters for Pi hole", so I vote in favour of adding it.

@krystian3w
Copy link

krystian3w commented Jun 1, 2022

BTW: List is in #43


considerably better than "Polish filters for Pi hole", so I vote in favour of adding it.

But blocked different content:

  • KAD - phishing, malware, scam/fraud domains
  • Polish filters for Pi hole - ads/tracking servers

So repo needed use both:

New stats by badmojr https://github.com/badmojr/crosscheck/blob/main/results.md#httpsrawgithubusercontentcomfiltersheroeskadhostsmasterkadhoststxt

@ameshkov
Copy link
Member

Sorry for the late reply.

Here's what we need to add it:

  1. Title (KADHosts?)
  2. Very short list description in English

@krystian3w
Copy link

krystian3w commented Aug 17, 2022

IMO possible copy description from FiltersRegistry:

https://github.com/AdguardTeam/FiltersRegistry/blob/master/filters/ThirdParty/filter_232_KADPrzekrety/metadata.json (is really short).

That is origin source and converted to hosts on own environment.

Also Possible consider join with specific regexes for Pi-Hole (a separate file due to the limitations of pi-hole and standard DNS services):

https://github.com/FiltersHeroes/KADhosts/raw/master/KADhole.txt (few manually added to file = mainly for blocking domains that use some kind of repeating pattern / enforce block subdomains in bad scenarios)

If regex is out of scope then no needed is combine files.



Or always convert origin file by AdGuard environment (but this shouldn't touch $third-party and $popup = the main sins of NextDNS when converting EasyList), in the future it might be better e.g. dns will support regexes or even paths (so more than hosts and pi-hole).

@antek821
Copy link
Author

The title I think might just be: KADHosts (Or KADHole if you decide to follow the suggestions in the previous message)

Description as @krystian3w wrote above

@ameshkov
Copy link
Member

ameshkov commented Dec 6, 2022

Both AdGuard DNS and AdGuard Home support regular expressions, but we prefer traditional ad blocking syntax:
https://adguard-dns.io/kb/general/dns-filtering-syntax/#regular-expressions

@krystian3w would it be possible to compile a file with additional regular expressions with the syntax AG products understand?

@ameshkov ameshkov added the in progress The request is accepted, but it requires some additional work on our side label Dec 6, 2022
@krystian3w
Copy link

krystian3w commented Dec 6, 2022

I think possible, but I suppose most exists in origin file https://raw.githubusercontent.com/FiltersHeroes/KAD/master/KAD.txt,
written for uBo and standard AdGuard extension/apps (strict block wall stylized like anti malware warning).

A few uses wildcard ABP syntax (with automatic translation to Pi-Hole regex syntax - due lack of documentation about support now wildcards).

Then to check are:

  • his compatible regex syntax (when they are not overkilled e.g. limited with domain= to better performance rest of pages on the Internet or not compatible with enforced RE2 like form manifest V3 (DNR)) and
  • support block subdomains when main page is blocked by AdGuard Home (I don't see this in table compare why is better than Pi-Hole) (DNS should block subdomains too and for me a little better to checking).

@ameshkov
Copy link
Member

ameshkov commented Dec 6, 2022

Wouldn't it be easier to simply use https://raw.githubusercontent.com/FiltersHeroes/KAD/master/KAD.txt as a source for KADHosts here?

@ameshkov
Copy link
Member

ameshkov commented Dec 6, 2022

Alternatively, to make it more "manageable", can we request adding an AdGuard Home version of KADHosts that uses DNS filtering syntax? The list that you linked is okay, but AdGuard Home / AdGuard DNS do not support $all modifier, it needs to be stripped to make it fully compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress The request is accepted, but it requires some additional work on our side
Projects
None yet
Development

No branches or pull requests

5 participants