Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The validator removes valid rules. #63

Open
Sergey-Lyapin opened this issue Mar 19, 2024 · 2 comments
Open

The validator removes valid rules. #63

Sergey-Lyapin opened this issue Mar 19, 2024 · 2 comments
Assignees
@jellizaveta
Labels
bug Something isn't working

Comments

@Sergey-Lyapin
Copy link

Sergey-Lyapin commented Mar 19, 2024 •
edited
Loading

Validator removes such rules, although when added to user rules they work.:

||asia^$denyallow=amzn.asia
||bar^$denyallow=fap.bar
||beauty^$denyallow=homelab.beauty|nic.beauty|vipbj.beauty

By the way, the validator considers such rules valid:

||*.asia^$denyallow=amzn.asia
||*.bar^$denyallow=fap.bar
||*.beauty^$denyallow=homelab.beauty|nic.beauty|vipbj.beauty

Example:
https://raw.githubusercontent.com/hagezi/dns-blocklists/main/adblock/spam-tlds.txt > validating >
https://github.com/AdguardTeam/HostlistsRegistry/blob/main/filters/security/filter_56_TheWorldsMostAbusedTLDs/filter.txt
@hagezi
Copy link

hagezi commented Mar 19, 2024 •
edited
Loading

@Sergey-Lyapin I can fix this in the list.

hagezi added a commit to hagezi/dns-blocklists that referenced this issue Mar 19, 2024
@hagezi
fix for HostlistCompiler - AdguardTeam/HostlistCompiler#62 - AdguardT…
0bafe8c 
…eam/HostlistCompiler#63
@hagezi
Copy link

hagezi commented Mar 19, 2024

Has been fixed in the list.

@ameshkov ameshkov added the bug Something isn't working label Mar 19, 2024
adguard pushed a commit that referenced this issue Dec 23, 2024
@jellizaveta
Fix validation of TLD domains. #63
d6c545e 
Squashed commit of the following:

commit db11c98
Author: Slava Leleka <[email protected]>
Date:   Sun Dec 22 22:53:24 2024 +0300

    add release date

commit 6df0c77
Author: Slava Leleka <[email protected]>
Date:   Sat Dec 21 11:58:50 2024 +0300

    Applied suggestion

commit b15d7f4
Author: Slava Leleka <[email protected]>
Date:   Sat Dec 21 11:58:45 2024 +0300

    Applied suggestion

commit 3579f0c
Author: jellizaveta <[email protected]>
Date:   Fri Dec 20 16:58:22 2024 +0300

    readme, add case with composite TLDs

commit dad1a78
Author: jellizaveta <[email protected]>
Date:   Thu Dec 19 11:57:56 2024 +0300

    add todo

commit d20db9c
Author: jellizaveta <[email protected]>
Date:   Thu Dec 19 11:55:32 2024 +0300

    remove redundant rule

commit ed53fb2
Merge: 3448837 eac70e2
Author: jellizaveta <[email protected]>
Date:   Thu Dec 19 11:54:29 2024 +0300

    merge

commit 3448837
Author: jellizaveta <[email protected]>
Date:   Thu Dec 19 11:53:03 2024 +0300

    add tests

commit 5654e6f
Author: jellizaveta <[email protected]>
Date:   Thu Dec 19 11:45:47 2024 +0300

    fix var name

commit 6aa69ef
Author: jellizaveta <[email protected]>
Date:   Thu Dec 19 11:44:38 2024 +0300

    update changelog

commit cc59b99
Merge: fc54e6b 85e2953
Author: jellizaveta <[email protected]>
Date:   Thu Dec 19 11:43:38 2024 +0300

    merge master

commit eac70e2
Author: Slava Leleka <[email protected]>
Date:   Wed Dec 18 18:05:44 2024 +0300

    Applied suggestion

commit 7b7022c
Author: Slava Leleka <[email protected]>
Date:   Wed Dec 18 18:04:05 2024 +0300

    Applied suggestion

commit fc54e6b
Author: Slava Leleka <[email protected]>
Date:   Wed Dec 18 17:04:09 2024 +0300

    Applied suggestion

commit b8375db
Author: jellizaveta <[email protected]>
Date:   Wed Dec 18 12:03:06 2024 +0300

    update changelog

commit a2c8adc
Author: jellizaveta <[email protected]>
Date:   Wed Dec 18 12:00:31 2024 +0300

    handle cases with wildcard in adblock style syntax

commit 22e49a9
Author: jellizaveta <[email protected]>
Date:   Fri Dec 13 17:36:14 2024 +0300

    allow TLD if limiting modifiers present

commit f946f3a
Author: jellizaveta <[email protected]>
Date:   Fri Dec 13 16:55:07 2024 +0300

    add test
@jellizaveta jellizaveta mentioned this issue Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jellizaveta jellizaveta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ameshkov @Sergey-Lyapin @jellizaveta @hagezi