From 38ef1848dc3e3c8237382de4d724c18f9c60651a Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Wed, 23 Oct 2024 19:14:36 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Kevin Anderson --- pvanalytics/quality/irradiance.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvanalytics/quality/irradiance.py b/pvanalytics/quality/irradiance.py index 5e2987e5..a62fc125 100644 --- a/pvanalytics/quality/irradiance.py +++ b/pvanalytics/quality/irradiance.py @@ -312,7 +312,7 @@ def check_irradiance_consistency_qcrad(solar_zenith, ghi, dhi, dni, value is a dict with keys 'zenith_bounds', 'ghi_bounds', and 'ratio_bounds' and value is an ordered pair [lower, upper] of float. - outside_domain : default False + outside_domain : bool, default False Value to return when the tests are not applicable, i.e., when the input data fall outside the test domain. @@ -326,7 +326,7 @@ def check_irradiance_consistency_qcrad(solar_zenith, ghi, dhi, dni, Notes ----- The QCRad algorithm checks that the input GHI is consistent with the - component sum :math:`DNI \times \cos \( zenith \) + DHI` of input DNI and + component sum :math:`DNI \times \cos ( zenith ) + DHI` of input DNI and DHI, and that the ratio :math:`\frac{DHI}{GHI}` is reasonable. In these two parts, the ``ghi_bounds`` are applied differently. In the