Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Java should be disabled by default #964

Open
simonjwright opened this issue Jan 21, 2024 · 2 comments
Open

Building Java should be disabled by default #964

simonjwright opened this issue Jan 21, 2024 · 2 comments

Comments

@simonjwright
Copy link

Building v24.0.0, I have to do

    python manage.py                            \
           build                                \
           --disable-java

or I get

Building the Java bindings...
Maven-Command failed: error while running mvn -f /Volumes/Miscellaneous3/src/libadalang/build/java/pom.xml clean package -q:
    [Errno 2] No such file or directory: 'mvn'

I don't have mvn installed, because I didn't know I might need to.

I think that people who want Java support should have to say --enable-java.

@raph-amiard
Copy link
Member

Hi @simonjwright! Thanks for the feedback.

This is a consequence of our internal build chain: Most of LAL developpers in-house will need the Java bindings anyway. We'll discuss to see if there's something more user friendly to do for external contributors.

Kind regards

@simonjwright
Copy link
Author

OK. But, would it be possible to alter user_manual/building.rst to mention this? (I could raise a PR if that would help? at least it would be from the viewpoint of an external user!)

okellogg pushed a commit to okellogg/libadalang that referenced this issue Apr 28, 2024
Fix specific_type in case of discrete base subtype

Closes AdaCore#964

See merge request eng/libadalang/libadalang!1280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants