Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent declarations #75

Open
pjljvandelaar opened this issue Dec 20, 2022 · 1 comment
Open

Inconsistent declarations #75

pjljvandelaar opened this issue Dec 20, 2022 · 1 comment

Comments

@pjljvandelaar
Copy link
Contributor

pjljvandelaar commented Dec 20, 2022

Hi Gnatcoll developers,

As you can see e.g. in

Prefix : Offset_Array (1 .. From_String'Length);
Reverse_Prefix : Offset_Array (1 .. From_String'Length);
K, K2 : Natural := 0;

some declarations are combined,
while others are kept apart.

Do you want to be consistent in this aspect?
So either

 Prefix          : Offset_Array (1 .. From_String'Length); 
 Reverse_Prefix  : Offset_Array (1 .. From_String'Length); 
 K               : Natural := 0; 
 K2              : Natural := 0; 

or

 Prefix, Reverse_Prefix  : Offset_Array (1 .. From_String'Length); 
 K, K2                   : Natural := 0; 

If so, using the rejuvenation library we can rewrite the code to the desired format.

Greetings,
Pierre

Problem detected and solvable using Rejuvenation-Ada crate
vote for Rejuvenation-Ada as The 2022 Ada Crate Of The Year

@Jicquel
Copy link
Collaborator

Jicquel commented Mar 19, 2024

Hello pjljvandelaar, thank you for opening this issue. You can open a PR with the modification you suggested, and I will take care of it. I would prefer for the more compact version, so the second one in your example. Please be aware that we would like to keep our current coding style, as already discussed in the other PR you opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants