Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS.Client mangles query parameters. #382

Open
Rombobeorn opened this issue Sep 23, 2024 · 0 comments
Open

AWS.Client mangles query parameters. #382

Rombobeorn opened this issue Sep 23, 2024 · 0 comments

Comments

@Rombobeorn
Copy link

AWS.Client mangles query parameters in some cases by percent-encoding the wrong character.

Here's an example that's easy to reproduce: Apache HTTPD can output file lists on request. A URL like "https://example.net/dir/?C=S;O=D" asks the server to sort the files by size in descending order. AWS.Client.Get sends that URL as "/dir/?C=S;O%3DD". The second equals sign gets encoded to not have any particular meaning. Thus Apache doesn't recognize the parameter "O=D", and sorts in ascending order instead.

A server that generates its own URLs is free to use any syntax it wants in the query part. A client-side library that receives ready-made URLs shall pass them through unmangled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant