Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize consecutive message field assignments #1120

Closed
Tracked by #908
treiher opened this issue Jul 27, 2022 · 0 comments · Fixed by #1134
Closed
Tracked by #908

Optimize consecutive message field assignments #1120

treiher opened this issue Jul 27, 2022 · 0 comments · Fixed by #1134
Assignees
Labels
generator Related to generator package (SPARK code generation) model Related to model package (e.g., model verification)

Comments

@treiher
Copy link
Collaborator

treiher commented Jul 27, 2022

Consecutive assignments to fields of the same message should be realizable with fewer checks:

  • Check Available_Space once
  • Check Valid_Next once

The assignments could be collected into a new object ("delta message aggregate"). It has to be checked that the set fields are a valid sub-path of the message. For the calculation of the required size, Message.size must consider message sub-paths.

Note: Field_Condition has to be checked on certain fields in case a condition could be violated. Field_Condition is not yet checked and adding of such checks is not part of this ticket, but will be done in #1121.

@treiher treiher added generator Related to generator package (SPARK code generation) model Related to model package (e.g., model verification) labels Jul 27, 2022
@treiher treiher self-assigned this Jul 27, 2022
treiher added a commit that referenced this issue Aug 11, 2022
treiher added a commit that referenced this issue Aug 12, 2022
treiher added a commit that referenced this issue Aug 16, 2022
treiher added a commit that referenced this issue Aug 16, 2022
treiher added a commit that referenced this issue Aug 16, 2022
treiher added a commit that referenced this issue Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Related to generator package (SPARK code generation) model Related to model package (e.g., model verification)
Projects
None yet
1 participant