Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rachael Water Class #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RachaelGomez
Copy link

No description provided.

Rachael Gomez and others added 2 commits June 2, 2021 15:44
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Rachael, you hit the learning goals here. Nice work.

if input.key < here.key
if here.left != nil
here = here.left
else here.left = input

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, just it's not standard coding style.

Suggested change
else here.left = input
else
here.left = input

else input.key > here.key
if here.right != nil
here = here.right
else here.right = input

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else here.right = input
else
here.right = input

Comment on lines 51 to 53
# Time Complexity:
# Space Complexity:
def find(key)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 space/time complexity?

Comment on lines 70 to 72
# Time Complexity:
# Space Complexity:
def inorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 space/time complexity?

Comment on lines 92 to 94
# Time Complexity:
# Space Complexity:
def preorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 space/time complexity?

Comment on lines 114 to 116
# Time Complexity:
# Space Complexity:
def postorder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 space/time complexity?

Comment on lines 135 to 137
# Time Complexity:
# Space Complexity:
def height

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 space/time complexity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants