Aimee 👾 - Fire 🔥 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 15, 2021
Comment on lines
+3
to
5
| // Time Complexity: O(n^3) - outer while loop (line 10) has a nested for loop (lines 24 and 27), it also has .splice() nested in a for loop, but this should still be O(n^3) overall. | ||
| // Space Complexity: O(n) - result, hash, and matched will be at most length n, where n is the number of elements in the strings array. Even though result is a nested array, it will never contain more than n elements. | ||
| function grouped_anagrams(strings) { |
There was a problem hiding this comment.
Suggestion: Sort the letters in each word and use that as a key to a hash and make the value a list of words with those letters.
Comment on lines
+53
to
55
| // Time Complexity: O(nlog(n)) - uses javascript sort, where n is the unique number of elements (worst case) | ||
| // Space Complexity: O(n) - the hash object will never have more than n number of key-value pairs (based on what elements are in list), and the result array will never have more than n elements, where n is the value of k | ||
| function top_k_frequent_elements(list, k) { |
Comment on lines
+91
to
93
| // Time Complexity: O(n) | ||
| // Space Complexity: O(n) | ||
| function valid_sudoku(table) { |
There was a problem hiding this comment.
👍 Fun fact, since a Sudoku board is always 9x9, this problem is actually O(1) !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions