Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicitly set macOS CI build architecture for C bindings. #406

Merged
merged 1 commit into from
May 11, 2024

Conversation

bruvzg
Copy link
Contributor

@bruvzg bruvzg commented May 5, 2024

Fixes #400

macos-latest GitHub CI runners are now using arm64 image, and cmake for C bindings determine target folder based on the current system architecture if it's not set explicitly, and x86_64 build was overwriting arm64 build artifacts:

Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bruvzg!

@DataTriny DataTriny merged commit 64857e8 into AccessKit:main May 11, 2024
10 checks passed
@mwcampbell mwcampbell mentioned this pull request May 11, 2024
@bruvzg bruvzg deleted the fix_macos_ci branch May 16, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accesskit_c: v0.9.0 - missing and mixed up macOS library architectures
2 participants