Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need methods for traversing nodes, including unignored nodes #4

Closed
mwcampbell opened this issue Sep 21, 2021 · 2 comments · Fixed by #40
Closed

Need methods for traversing nodes, including unignored nodes #4

mwcampbell opened this issue Sep 21, 2021 · 2 comments · Fixed by #40

Comments

@mwcampbell
Copy link
Contributor

Belatedly opening an issue for this. #3 is addressing this; I just need to review it.

@DataTriny
Copy link
Member

Some custom iterators that are part of #3 currently yield NodeId when they should return Node<'_>,. This force us to perform more hash table lookups due to the fact that the Iterator trait is not able to yield items that reference the custom iterator struct itself. It appears that this is a well-known issue of current Rust, and that Generic Associated Types could improve the situation.
Therefore, I would suggest keeping this issue open, or opening a dedicated one so we can track this optimization opportunity.

@mwcampbell
Copy link
Contributor Author

See #39 for a discussion on the lifetime challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants