Fix OSX specific CI issues #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the work! We'll have a look, some of us have Apple hardware to test on. |
|
@tomsmeding If you approve this workflow, I can work at it over the weekend |
|
I'm seeing some capstone-related errors in the macos CI; I'm currently upgrading tracy, and the new tracy version downloads and builds its own capstone. Let's see if that works better. |
It turns out that .init_array is a Linuxism, so we now use
__attribute__((constructor)) on Mac, section(".init_array") on Linux,
and still nothing on Windows because what even can we do.
|
It turns out that the |
|
Ah meh this CI run would be pointless anyway because it's going to succeed for macos-release and fail for macos-debug for Tracy reasons. |
|
Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes OSX-specific CI issues which don't happen on other platforms.
This PR will remain in draft state until I can figure out what's wrong -- I don't have Apple hardware to test locally