Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4599: Perform endian byteswap on correct buffer area for PSD RLE #4600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jessey-git
Copy link
Contributor

Description

Perform the endian byteswap on the correct buffer area for PSD RLE decoding. The original code used dst but that pointer is modified from its original value as it progresses through decoding.

Fixes #4599

Tests

It might be prudent to add a test for this. Is the repro file attached to the bug too big for this repo(842kb) or do you want them in the oiio-images repo maybe?

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • If I added or modified a C++ API call, I have also amended the
    corresponding Python bindings (and if altering ImageBufAlgo functions, also
    exposed the new functionality as oiiotool options).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

…t buffer area for PSD RLE decoding

Signed-off-by: Jesse Yurkovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Crash when reading certain PSD files
1 participant