-
Notifications
You must be signed in to change notification settings - Fork 460
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Parsing: use <charconv> from_chars on C++17
When building for C++17 or later, NumberUtils can use standard <charconv> from_chars functions (except on Apple platforms, where those are not implemented for floating point types as of Xcode 15). This has advantage of not having to deal with errno nor locales. Saves some thread local storage accesses and function calls (e.g. on Windows errno is actually a function call). With these changes, parsing Khronos PBR Neutral Iridas .cube file (5.4MB) on Ryzen 5950X / VS2022 Release build: 142ms -> 123ms There's a CMake setup change that adds "/Zc:__cplusplus" flag for MSVC; for backwards compat reasons it does not report proper C++ version detection defines otherwise.
- Loading branch information
Showing
2 changed files
with
48 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters