Fix { and address code review comments

Signed-off-by: Rosie Wang <[email protected]>
AcademySoftwareFoundation · Aug 19, 2024 · 1f0fdb2 · 1f0fdb2
1 parent 5befeb7
commit 1f0fdb2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/OpenColorIO/GpuShaderUtils.cpp b/src/OpenColorIO/GpuShaderUtils.cpp
@@ -223,9 +223,12 @@ std::string getMatrixValues(const T * mtx, GpuLanguage lang, bool transpose)
 }
 
 
-void RGBtoRGBATexture(const float* lutValues, int valueCount, std::vector<float>& float4AdaptedLutValues){
+void RGBtoRGBATexture(const float* lutValues, int valueCount, std::vector<float>& float4AdaptedLutValues)
+{
     if(valueCount % 3 != 0)
+    {
         throw Exception("Value count should be divisible by 3.");
+    }
 
     valueCount = valueCount * 4 / 3;
     if(lutValues != nullptr)
@@ -235,7 +238,8 @@ void RGBtoRGBATexture(const float* lutValues, int valueCount, std::vector<float>
         float *rgbaLutValuesIt = float4AdaptedLutValues.data();
         const float *end = rgbaLutValuesIt + valueCount;
 
-        while(rgbaLutValuesIt != end) {
+        while(rgbaLutValuesIt != end) 
+        {
             *rgbaLutValuesIt++ = *rgbLutValuesIt++;
             *rgbaLutValuesIt++ = *rgbLutValuesIt++;
             *rgbaLutValuesIt++ = *rgbLutValuesIt++;

diff --git a/src/OpenColorIO/ops/lut1d/Lut1DOpGPU.cpp b/src/OpenColorIO/ops/lut1d/Lut1DOpGPU.cpp
@@ -186,9 +186,10 @@ void GetLut1DGPUShaderProgram(GpuShaderCreatorRcPtr & shaderCreator,
         CreatePaddedLutChannels(width, height, lutData->getArray().getValues(), values);
         channel = GpuShaderCreator::TEXTURE_RGB_CHANNEL;
         break;
-    case 4: {
+    case 4: 
+    {
         std::vector<float> paddedChannels;
-        values.reserve(width * height * 3);
+        paddedChannels.reserve(width * height * 3);
         CreatePaddedLutChannels(width, height, lutData->getArray().getValues(), paddedChannels);
         // Insert a place holder alpha channel with value of 1. This is to support RGBA 
         // texture format for Metal shading language.